Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-2422 FederatedStore ChangeGraphId & ChangeGraphAccess update cache… #2424

Conversation

GCHQDev404
Copy link
Contributor

@GCHQDev404 GCHQDev404 commented May 12, 2021

@codecov-commenter
Copy link

codecov-commenter commented May 12, 2021

Codecov Report

Merging #2424 (d377b4f) into develop (8a2d802) will increase coverage by 6.74%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2424      +/-   ##
=============================================
+ Coverage      66.14%   72.88%   +6.74%     
+ Complexity      2169      411    -1758     
=============================================
  Files            908       66     -842     
  Lines          30952     1184   -29768     
  Branches        3801       83    -3718     
=============================================
- Hits           20474      863   -19611     
+ Misses          8861      258    -8603     
+ Partials        1617       63    -1554     
Impacted Files Coverage Δ
...k/gov/gchq/gaffer/mapstore/multimap/MapOfSets.java
...a/uk/gov/gchq/gaffer/data/element/id/EntityId.java
...va/uk/gov/gchq/gaffer/graph/GraphSerialisable.java
.../main/java/uk/gov/gchq/gaffer/types/TypeValue.java
...java/uk/gov/gchq/gaffer/hbasestore/HBaseStore.java
...gov/gchq/gaffer/operation/graph/OperationView.java
.../implementation/ordered/OrderedLongSerialiser.java
...gchq/gaffer/accumulostore/utils/BytesAndRange.java
.../gchq/gaffer/exception/SerialisationException.java
...erialisation/implementation/BooleanSerialiser.java
... and 935 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 857cb2a...d377b4f. Read the comment docs.

@n3101
Copy link

n3101 commented May 18, 2021

@GCHQDev404 Is this a breaking change? (Sorry, I have to ask this about every PR as you are doing gaffer 2 work)

@GCHQDev404 GCHQDev404 self-assigned this May 30, 2021
@GCHQDev404 GCHQDev404 marked this pull request as draft May 30, 2021 15:31
@GCHQDev404 GCHQDev404 marked this pull request as ready for review May 30, 2021 15:31
@GCHQDev404 GCHQDev404 marked this pull request as draft May 30, 2021 15:33
@GCHQDev404 GCHQDev404 closed this May 30, 2021
@GCHQDev404
Copy link
Contributor Author

closed due to gh-2435

@GCHQDev404 GCHQDev404 deleted the gh-2422-FederatedStore-update-chache-with-graph-changes branch June 3, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FederatedStore ChangeGraphId & ChangeGraphAccess updated cache
3 participants