-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-2552: Removed deprecated code #2563
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2563 +/- ##
=============================================
- Coverage 66.69% 65.27% -1.43%
+ Complexity 2522 2430 -92
=============================================
Files 995 870 -125
Lines 32457 27152 -5305
Branches 3936 3164 -772
=============================================
- Hits 21647 17723 -3924
+ Misses 9114 8032 -1082
+ Partials 1696 1397 -299
Continue to review full report at Codecov.
|
* It has been marked deprecated but will not be removed as it is needed | ||
* in the Serialiser interface. | ||
* @see #deserialise(byte[], int, int) | ||
*/ | ||
@Deprecated | ||
@Override | ||
public final T deserialise(final byte[] bytes) throws SerialisationException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function, as well as ToBytesSerialiser.deserialise(byte[]), have been left in despite being deprecated. This is because they cannot be removed as they need to have implementations for the Serialiser interface. However, the deprecated tag has been left in to warn people to instead use the more efficient deserialise(byte[], int, int) method instead.
Closing as this was meant to merge into v2-alpha branch |
This branch is not yet complete, still todo:
includeMatchedVertex
is added inAccumuloElementsRetriever
Related Issue