Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-2552: Removed deprecated code #2563

Closed
wants to merge 2 commits into from
Closed

Conversation

t92549
Copy link
Contributor

@t92549 t92549 commented Jan 13, 2022

This branch is not yet complete, still todo:

Related Issue

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2022

Codecov Report

Merging #2563 (c7fd1e3) into develop (4ccb03f) will decrease coverage by 1.42%.
The diff coverage is 92.85%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2563      +/-   ##
=============================================
- Coverage      66.69%   65.27%   -1.43%     
+ Complexity      2522     2430      -92     
=============================================
  Files            995      870     -125     
  Lines          32457    27152    -5305     
  Branches        3936     3164     -772     
=============================================
- Hits           21647    17723    -3924     
+ Misses          9114     8032    -1082     
+ Partials        1696     1397     -299     
Impacted Files Coverage Δ
...r/data/elementdefinition/view/NamedViewDetail.java 45.39% <ø> (+0.27%) ⬆️
.../elementdefinition/view/ViewElementDefinition.java 63.08% <ø> (+0.58%) ⬆️
.../src/main/java/uk/gov/gchq/gaffer/graph/Graph.java 68.73% <ø> (+3.72%) ⬆️
...ain/java/uk/gov/gchq/gaffer/graph/GraphConfig.java 55.26% <0.00%> (ø)
.../java/uk/gov/gchq/gaffer/jobtracker/JobDetail.java 32.62% <ø> (+3.32%) ⬆️
...n/java/uk/gov/gchq/gaffer/operation/Operation.java 75.00% <ø> (+1.41%) ⬆️
...va/uk/gov/gchq/gaffer/operation/impl/GetWalks.java 81.13% <ø> (-1.12%) ⬇️
...ov/gchq/gaffer/operation/impl/get/GetElements.java 69.23% <ø> (-0.27%) ⬇️
...ffer/operation/impl/join/methods/JoinFunction.java 100.00% <ø> (+4.00%) ⬆️
.../gchq/gaffer/jsonserialisation/JSONSerialiser.java 75.70% <ø> (+1.38%) ⬆️
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 296c453...c7fd1e3. Read the comment docs.

* It has been marked deprecated but will not be removed as it is needed
* in the Serialiser interface.
* @see #deserialise(byte[], int, int)
*/
@Deprecated
@Override
public final T deserialise(final byte[] bytes) throws SerialisationException {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function, as well as ToBytesSerialiser.deserialise(byte[]), have been left in despite being deprecated. This is because they cannot be removed as they need to have implementations for the Serialiser interface. However, the deprecated tag has been left in to warn people to instead use the more efficient deserialise(byte[], int, int) method instead.

@t92549
Copy link
Contributor Author

t92549 commented Jan 14, 2022

Closing as this was meant to merge into v2-alpha branch

@t92549 t92549 closed this Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Deprecated code
2 participants