gh-2552-remove-deprecated MultiSerialiser #2587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCHQDev404
commented
Feb 14, 2022
| * }, | ||
| * "valueClass" : "java.lang.Integer" | ||
| * }, { | ||
| * "key" : 8, | ||
| * "serialiser" : { | ||
| * "class" : "uk.gov.gchq.gaffer.serialisation.implementation.ordered.OrderedIntegerSerialiser" | ||
| * "class" : "uk.gov.gchq.gaffer.serialisation.implementation.raw.CompactRawIntegerSerialiser" |
There was a problem hiding this comment.
assumption that this is still ordered because that was the reason for removing the old RawIntegerSerialiser.
update the MultiSerialiser wanting to emphasise the effectiveness of it during the deprecation of serialisers. 8 is the last and best. 24 is not latest regardless of natural-order. 7 is dead.
GCHQDev404
force-pushed
the
gh-2552-remove-deprecated-MultiSerialiser
branch
from
99b84e6
to
fcb1d04
Compare
Codecov Report
@@ Coverage Diff @@
## gh-2552-remove-deprecated #2587 +/- ##
===============================================================
- Coverage 65.30% 65.28% -0.02%
+ Complexity 2429 2427 -2
===============================================================
Files 872 872
Lines 27209 27209
Branches 3165 3165
===============================================================
- Hits 17768 17764 -4
- Misses 8044 8046 +2
- Partials 1397 1399 +2
Continue to review full report at Codecov.
|
t92549
requested changes
Feb 14, 2022
...alisation/src/main/java/uk/gov/gchq/gaffer/serialisation/implementation/MultiSerialiser.java
Outdated
Show resolved
Hide resolved
...alisation/src/main/java/uk/gov/gchq/gaffer/serialisation/implementation/MultiSerialiser.java
Outdated
Show resolved
Hide resolved
...alisation/src/main/java/uk/gov/gchq/gaffer/serialisation/implementation/MultiSerialiser.java
Outdated
Show resolved
Hide resolved
...alisation/src/main/java/uk/gov/gchq/gaffer/serialisation/implementation/MultiSerialiser.java
Outdated
Show resolved
Hide resolved
...alisation/src/main/java/uk/gov/gchq/gaffer/serialisation/implementation/MultiSerialiser.java
Outdated
Show resolved
Hide resolved
t92549
approved these changes
Feb 17, 2022
...alisation/src/main/java/uk/gov/gchq/gaffer/serialisation/implementation/MultiSerialiser.java
Show resolved
Hide resolved
...alisation/src/main/java/uk/gov/gchq/gaffer/serialisation/implementation/MultiSerialiser.java
Outdated
Show resolved
Hide resolved
GCHQDev404
commented
Feb 18, 2022
...alisation/src/main/java/uk/gov/gchq/gaffer/serialisation/implementation/MultiSerialiser.java
Outdated
Show resolved
Hide resolved
…ion/implementation/MultiSerialiser.java
GCHQDeveloper314
approved these changes
Feb 18, 2022
t92549
added a commit
that referenced
this pull request
Feb 23, 2022
* gh-2552: Removed deprecated code except getTraits and hasTrait * gh-2552: Fix javadoc issue * gh-2571: Fixed matchedVertex behaviour and added new ITs (#2572) * gh-2571: Fixed matchedVertex behaviour and added new ITs * gh-2571: Fixed checkstyle * gh-2571: Updated test name * gh-2573: Replace hasTrait usages with Operation (#2574) * gh-2573: Replace hasTrait usages with Operation * gh-2573: Fix tests by making exception more explicit * gh-2573: Fixed exception issues * gh-2573: Simplified but still failing test * gh-2573: Changed to user * gh-2573: Changed FederatedGetTraitsHandler to return DYNAMIC_SCHEMA * gh-2573: Use old function for FederatedOperationChainValidator * gh-2573: Fixed FederatedStoreUtil * gh-2573: Added Deprecation notice * gh-2573: Cherry pick federated store tests fix from 2553 * Revert "gh-2573: Cherry pick federated store tests fix from 2553" This reverts commit c367555. * gh-2573: Manual fix of FederatedStoreGetTraitsTest cache * gh-2573: Changed HasTraitHandler to not send Federated loop option * Gh-2560 get traits operation configurable (#2579) * Update docs links in README * Revert "Update docs links in README" This reverts commit 2d87bf3. * gh-2559 added hasTrait, its handler and corresponding tests (#2561) * gh-2559 added hasTrait, its handler and corresponding tests * gh-2559 amended comment in HasTrait, added additional tests for the handler * gh-2559 null check & tidy test Co-authored-by: t92549 <80890692+t92549@users.noreply.github.com> * Update links to Gaffer docs in all files (#2566) Co-authored-by: t92549 <80890692+t92549@users.noreply.github.com> * gh-2560 GetTraitsHandler is initalised with traits dependednt on store type * gh-2560 reviewed comments * gh-2560 unused imports * gh-2560 review comments * checkstyle * gh-2560 fixed federated test * gh-2560 fixed GraphTest * gh-2560 fixed TestStore * gh-2560-getTraitsOperation (#2582) Removing redundant adding of GetTraitHandler from addAdditionalOperationHandlers() because it has its own method getGetTraitsHandler(). * gh-2560: Added fix to SingleUseMapStoreWithoutVisibilitySupport * gh-2560: Fixed Set copy issue in GetTraitsHandler constructor * gh-2560: Added extra protections to GetTraitsHandler Co-authored-by: GCHQDeveloper314 <94527357+GCHQDeveloper314@users.noreply.github.com> Co-authored-by: t92549 <80890692+t92549@users.noreply.github.com> Co-authored-by: GCHQDev404 <45399082+GCHQDev404@users.noreply.github.com> * gh-2552: Removed some remaining parquet properties files * gh-2552: Review comments traits test * gh-2552-remove-deprecated MultiSerialiser (#2587) * gh-2552-remove-deprecated MultiSerialiser update the MultiSerialiser wanting to emphasise the effectiveness of it during the deprecation of serialisers. 8 is the last and best. 24 is not latest regardless of natural-order. 7 is dead. * gh-2552: MultiSerialiser spelling corrections * Update core/serialisation/src/main/java/uk/gov/gchq/gaffer/serialisation/implementation/MultiSerialiser.java Co-authored-by: t92549 <80890692+t92549@users.noreply.github.com> Co-authored-by: p3430233 <61738524+p3430233@users.noreply.github.com> Co-authored-by: GCHQDeveloper314 <94527357+GCHQDeveloper314@users.noreply.github.com> Co-authored-by: GCHQDev404 <45399082+GCHQDev404@users.noreply.github.com>
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update the MultiSerialiser wanting to emphasise the effectiveness of it during the deprecation of serialisers.
8 is the last and best.
24 is not latest regardless of natural-order.
7 is dead.
Related Issue