Gh 2816 federated store remove todos #2817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCHQDev404
force-pushed
the
gh-2816-FederatedStore-remove-todos
branch
from
7f5cb73
to
3aa0ad4
Compare
Codecov Report
@@ Coverage Diff @@
## v2-alpha #2817 +/- ##
===========================================
Coverage ? 63.96%
Complexity ? 2462
===========================================
Files ? 712
Lines ? 21867
Branches ? 2517
===========================================
Hits ? 13987
Misses ? 6742
Partials ? 1138 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
GCHQDev404
force-pushed
the
gh-2816-FederatedStore-remove-todos
branch
from
3aa0ad4
to
9e32283
Compare
t92549
reviewed
Nov 11, 2022
core/store/src/main/java/uk/gov/gchq/gaffer/store/operation/handler/HasTraitHandler.java
Show resolved
Hide resolved
...ain/java/uk/gov/gchq/gaffer/federatedstore/operation/handler/FederatedDelegateToHandler.java
Show resolved
Hide resolved
...re/src/test/java/uk/gov/gchq/gaffer/federatedstore/util/ApplyViewToElementsFunctionTest.java
Outdated
Show resolved
Hide resolved
GCHQDev404
force-pushed
the
gh-2816-FederatedStore-remove-todos
branch
2 times, most recently
from
19f4ee0
to
49652b4
Compare
GCHQDev404
force-pushed
the
gh-2816-FederatedStore-remove-todos
branch
from
49652b4
to
98ae226
Compare
t92549
previously approved these changes
Nov 14, 2022
…Store-remove-todos # Conflicts: # store-implementation/federated-store/src/main/java/uk/gov/gchq/gaffer/federatedstore/FederatedStore.java
t92549
approved these changes
Nov 14, 2022
lb324567
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue