Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-2881-Problems with getOriginalSchema in Federated and Proxy Stores #2884

Merged
merged 18 commits into from
Feb 21, 2023
Merged

gh-2881-Problems with getOriginalSchema in Federated and Proxy Stores #2884

merged 18 commits into from
Feb 21, 2023

Conversation

GCHQDev404
Copy link
Contributor

@GCHQDev404 GCHQDev404 commented Feb 8, 2023 •
edited by github-actions bot
Loading

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (v2-alpha@5f22ae6). Click here to learn what that means.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##             v2-alpha    #2884   +/-   ##
===========================================
  Coverage            ?   56.61%           
  Complexity          ?     2494           
===========================================
  Files               ?      917           
  Lines               ?    32335           
  Branches            ?     3282           
===========================================
  Hits                ?    18307           
  Misses              ?    12648           
  Partials            ?     1380

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@GCHQDev404 GCHQDev404 linked an issue Feb 8, 2023 that may be closed by this pull request
Problems with getOriginalSchema in Federated and Proxy Stores #2881
Closed
@GCHQDev404 GCHQDev404 changed the title gh-2881-initial attempt gh-2881-getSchema-reform Feb 9, 2023
@GCHQDev404 GCHQDev404 changed the title gh-2881-getSchema-reform gh-2881-Problems with getOriginalSchema in Federated and Proxy Stores Feb 9, 2023
@GCHQDev404 GCHQDev404 marked this pull request as draft February 9, 2023 14:06
@GCHQDeveloper314
Copy link
Member

This PR also includes changes to remove use of and delete the following deprecated methods from the Federated Store:

  • getSchema from FederatedGraphStorage.java.
  • getFederatedWrappedSchema from FederatedStoreUtil.java.

6 tests from FederatedGraphStorageTest which had been marked as deprecated (due to using the above getSchema method) have been migrated to StoreSchemaTest.

@GCHQDeveloper314 GCHQDeveloper314 marked this pull request as ready for review February 17, 2023 17:21
@GCHQDev404
Copy link
Contributor Author

Approved.

@t92549 t92549 merged commit 9002d7e into v2-alpha Feb 21, 2023
@t92549 t92549 deleted the gh-2881_ProxyStore_fetchSchema branch February 21, 2023 14:09
@t92549 t92549 mentioned this pull request Feb 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t92549 t92549 t92549 approved these changes

@GCHQDeveloper314 GCHQDeveloper314 GCHQDeveloper314 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problems with getOriginalSchema in Federated and Proxy Stores
4 participants
@GCHQDev404 @codecov-commenter @GCHQDeveloper314 @t92549