Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh 2940: Merge develop into v2-alpha #2945

Merged
merged 27 commits into from
May 12, 2023
Merged

Gh 2940: Merge develop into v2-alpha #2945

merged 27 commits into from
May 12, 2023

Conversation

t92549
Copy link
Contributor

@t92549 t92549 commented May 11, 2023

Related Issue

GCHQDeveloper314 and others added 25 commits January 11, 2022 15:41
* gh-2559 added hasTrait, its handler and corresponding tests

* gh-2559 amended comment in HasTrait, added additional tests for the handler

* gh-2559 null check & tidy test

Co-authored-by: t92549 <80890692+t92549@users.noreply.github.com>
Co-authored-by: t92549 <80890692+t92549@users.noreply.github.com>
…2605)

* gh-2556: Add HBaseStore deprecated tag, javadocs and note to README

* gh-2556: Amend version number
Co-authored-by: t92549 <80890692+t92549@users.noreply.github.com>
* Replace Log4j with Reload4j
Also add enforcer plugin to prevent future problems
…arrying out each test causing it to fail when run as part of the maven tests. In isolation it passed. Found that the FederatedGraphStorageTraitsTest was also not clearing the cache. Added the before and after cache clearance and bumped the JUnit version of FederatedStoreGetTraitsTest from 4 to 5. Tests now pass (#2617)

Co-authored-by: r32575 <63105662+r32575@users.noreply.github.com>
…ties - Gaffer v1 (#2597)

* Fixed bug gh-2562. View properties are now being filtered. Added tests

* After a review moved the return statements inside the doPostFilter if-check and changed a conditional fail to an assertThat test

* Removed the try-finally blocks as the classes implement CloseableIterable

* Added failure message to test

* Adjusted javadoc formatting

* Removed rogue letter

Co-authored-by: t92549 <80890692+t92549@users.noreply.github.com>
* Found 1 extra inconsistency than the mentioned one

* found and fixed other inconsitencies

* further fixes

* further fixes 2

* fixed 3 out of 4 checkstyle errors - 1 more to fix

* all checkstyle errors fixed

* removed use of String.format

* removed another instance of using String.format

* more changes

* additional change

* reverted changes
* gh-2705: Cherry pick new spring endpoint

* gh-2696: Added tests for new all operation details endpoint (#2700)

* gh-2696: Added tests for new all operation details endpoint

* gh-2696: Spotless apply

* gh-2705: Copyright fix
Fixed Crown Copyright Link on Line 44
* Create issue templates

* Simplify bug report
Bumps [hazelcast](https://github.com/hazelcast/hazelcast) from 5.1.1 to 5.1.3.
- [Release notes](https://github.com/hazelcast/hazelcast/releases)
- [Commits](hazelcast/hazelcast@v5.1.1...v5.1.3)

---
updated-dependencies:
- dependency-name: com.hazelcast:hazelcast
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: t92549 <80890692+t92549@users.noreply.github.com>
* #2914 Issue: Remove redundant constants class

* Simplify charset

* Fix import

* Remove erroneous use of charset with JSONSerialiser.serialise

* Use StandardCharsets inbuilt function
---------

Co-authored-by: GCHQDeveloper314 <94527357+GCHQDeveloper314@users.noreply.github.com>
@CLAassistant
Copy link

CLAassistant commented May 11, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
8 out of 9 committers have signed the CLA.

✅ GCHQDeveloper314
✅ t92549
✅ p3430233
✅ r32575
✅ AnirbanPatragithub
✅ kvaithin
✅ ibrijesh
✅ RobertG111
❌ Gaffer


Gaffer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@t92549 t92549 linked an issue May 11, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented May 11, 2023

Codecov Report

❗ No coverage uploaded for pull request base (v2-alpha@cfa9b90). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##             v2-alpha    #2945   +/-   ##
===========================================
  Coverage            ?   56.12%           
  Complexity          ?     2476           
===========================================
  Files               ?      916           
  Lines               ?    32288           
  Branches            ?     3292           
===========================================
  Hits                ?    18123           
  Misses              ?    12776           
  Partials            ?     1389           

@t92549 t92549 marked this pull request as ready for review May 11, 2023 17:13
@t92549 t92549 merged commit 1bbd1dd into v2-alpha May 12, 2023
20 checks passed
@t92549 t92549 deleted the gh-2940-merge-develop branch May 12, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge develop into v2-alpha
10 participants