Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh 3059 pr refactor #3165

Conversation

GCHQDev404
Copy link
Contributor

@GCHQDev404 GCHQDev404 commented Feb 26, 2024

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 74.19355% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 66.40%. Comparing base (5316093) to head (41fde19).

Files Patch % Lines
...ffer/federatedstore/util/MergeElementFunction.java 68.88% 7 Missing and 7 partials ⚠️
.../gchq/gaffer/data/elementdefinition/view/View.java 66.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@                                         Coverage Diff                                         @@
##             gh-3059-federated-store-applyviewtoelements-schema-validation    #3165      +/-   ##
===================================================================================================
+ Coverage                                                            66.36%   66.40%   +0.03%     
  Complexity                                                            2544     2544              
===================================================================================================
  Files                                                                  907      907              
  Lines                                                                29005    29023      +18     
  Branches                                                              3221     3226       +5     
===================================================================================================
+ Hits                                                                 19250    19272      +22     
+ Misses                                                                8320     8312       -8     
- Partials                                                              1435     1439       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GCHQDev404 GCHQDev404 marked this pull request as ready for review February 26, 2024 23:13
@GCHQDev404 GCHQDev404 merged commit a715c34 into gh-3059-federated-store-applyviewtoelements-schema-validation Feb 27, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant