Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh-3200: Additional Federated Stores Tinkerpop tests #3204

Merged

Conversation

cn337131
Copy link
Member

@cn337131 cn337131 commented May 2, 2024

Added a few more tests of a federated store with a GafferPopGraph. These test whether the .with() config options allow users to specify the graph they wish to target for results using Gremlin.

Also an additional fix in GafferPopGraph which prevented Gremlin queries seeding with edge IDs in cases where edges were not directed.

Note: docs will need to be added that explain to users how to use the .with() to query federated graphs.

Related issue

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.86%. Comparing base (49a8d38) to head (c08d63d).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3204      +/-   ##
=============================================
- Coverage      66.87%   66.86%   -0.02%     
+ Complexity      2558     2556       -2     
=============================================
  Files            912      912              
  Lines          29284    29284              
  Branches        3268     3268              
=============================================
- Hits           19584    19580       -4     
- Misses          8256     8258       +2     
- Partials        1444     1446       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GCHQDeveloper314 GCHQDeveloper314 merged commit 9d904ca into develop May 9, 2024
25 of 26 checks passed
@GCHQDeveloper314 GCHQDeveloper314 deleted the gh-3200-additional-federated-stores-tinkerpop-tests branch May 9, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add additional tinkerpop tests to ensure config options work with FederatedStores
3 participants