Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network element uses abstract BaseNetworkComplexType #54

Closed
at055612 opened this issue Apr 15, 2019 · 2 comments
Closed

Network element uses abstract BaseNetworkComplexType #54

at055612 opened this issue Apr 15, 2019 · 2 comments
Assignees
@at055612
Labels
bug

Comments

@at055612
Copy link
Member

An element can't be of a type that is declared abstract
@at055612 at055612 added the bug label Apr 15, 2019
@at055612 at055612 self-assigned this Apr 15, 2019
@at055612
Copy link
Member Author

v3.4.1 made all Base....ComplxType types abstract, however there is a Network element that is of the type BaseNetworkComplexType. For reasons I don't understand this passed schema validation.

Need to rename NetworkComplexType to NetworkOutcomeComplexType and change uses of it. Then we need to create a new NetworkComplexType that simply extends the BaseNetworkComplexType.

This means a breaking change as far as the jaxb api goes.

at055612 added a commit that referenced this issue Apr 15, 2019
@at055612
gh-54 Rename NetworkComplexType to NetworkOutcome...
8e392b1 
Also add a new NetworkComplexType that just extends
BaseNetworkComplexType.
at055612 added a commit that referenced this issue Apr 15, 2019
@at055612
gh-54 Update CHANGELOG
cb252a0
at055612 added a commit that referenced this issue Apr 16, 2019
@at055612
gh-54 Add example XML for Network/Close and Alert/Network
811ac7e
at055612 added a commit that referenced this issue Apr 16, 2019
@at055612
gh-54 Uncomment test/identity pipelines, add documentation pipeline
258f876
@at055612 at055612 mentioned this issue Apr 16, 2019
Merged
at055612 added a commit that referenced this issue Apr 16, 2019
@at055612
Merge pull request #55 from gchq/gh-54-fix-network-complex-type
54d5e70 
Gh 54 fix network complex type
@at055612
Copy link
Member Author

fixed in >3.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@at055612 at055612

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@at055612