Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release publishes wrong artifacts #216

Closed
t92549 opened this issue Apr 1, 2022 · 1 comment · Fixed by #217
Closed

Release publishes wrong artifacts #216

t92549 opened this issue Apr 1, 2022 · 1 comment · Fixed by #217
Assignees
@t92549
Labels
automation GitHub Actions, CI/CD bug Confirmed or suspected bug
Milestone
v1.1.0

Comments

@t92549
Copy link
Contributor

t92549 commented Apr 1, 2022

The new release process doesn't wait for develop to be updated before checking it out and building/publishing the artifacts:

gaffer-docker/.github/workflows/release.yaml

Lines 137 to 138 in 2e436f1

needs:
- create-release-tag

This create-release-tag step merges to master now, not develop, and it now merges to develop later in update-branches.
This should be fixed for the next release and the old artifacts fixed manually.
@t92549 t92549 added the automation GitHub Actions, CI/CD label Apr 1, 2022
@t92549 t92549 added this to the v1.1.0 milestone Apr 1, 2022
@t92549 t92549 self-assigned this Apr 1, 2022
t92549 added a commit that referenced this issue Apr 1, 2022
@t92549
gh-216: Ensure that uploading release artifacts waits for develop to …
e4e55d8 
…be updated
@github-actions github-actions bot mentioned this issue Apr 1, 2022
Merged
@t92549 t92549 added the bug Confirmed or suspected bug label Apr 1, 2022
t92549 added a commit that referenced this issue Apr 4, 2022
@t92549
gh-216: Ensure that uploading release artifacts waits for develop to …
e26dbe7 
…be updated (#217)
@t92549
Copy link
Contributor Author

t92549 commented Apr 4, 2022

Not only were the release artifacts fixed manually, but the helm repo had to be manually fixed in the gh-pages branch with this commit: 00586fa

t92549 added a commit that referenced this issue Apr 4, 2022
@t92549
gh-216: Ensure that uploading release artifacts waits for develop to …
fa4677c 
…be updated (#217)
t92549 added a commit that referenced this issue May 5, 2022
@t92549
Gh 218 cherry pick release fix (#219)
e6b78ba 
* gh-216: Ensure that uploading release artifacts waits for develop to be updated (#217)

* gh-222: Change kind usages to use kubernetes 1.21
t92549 added a commit that referenced this issue May 16, 2023
@t92549 @ctas582
Gh 308: Merge develop (#309)
1c593ee 
* gh-216: Ensure that uploading release artifacts waits for develop to be updated (#217)

* gh-222: Change kind usages to use kubernetes 1.21 (#223)

* gh-225: Fix release action not seeing branch (#226)

* gh-98 Stop git from auto converting line endings on clone (#242)

* gh-221 Support networking.k8s.io/v1/Ingress and networking.k8s.io/v1beta1/Ingress (#247)

* gh-221 Support networking.k8s.io/v1/Ingress and networking.k8s.io/v1beta1/Ingress

* gh-221 Add tests

* Set kubernetes version to 1.24.4 in kind CI (#254)

* Gh 262 refactor integration tests (#263)

* Updated teams notification

* Consolidate develop release workflow with v2-alpha (#288)

* Update Gaffer version to 1.23.0 (#293)

* prepare release v1.1.0

* prepare release v1.1.1

* Change base image to Ubuntu focal (#295)

* Gh 302: Cherry-pick CI (#299)

---------

Co-authored-by: ctas582 <ctas582@users.noreply.github.com>
Co-authored-by: Gaffer <github-actions@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t92549 t92549

Labels
automation GitHub Actions, CI/CD bug Confirmed or suspected bug
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

gh-216: Ensure that uploading release artifacts waits for develop gchq/gaffer-docker
1 participant
@t92549