Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting a doc doesn't delete the doc_permission records for it #4278

Closed
at055612 opened this issue May 17, 2024 · 1 comment
Closed

Deleting a doc doesn't delete the doc_permission records for it #4278

at055612 opened this issue May 17, 2024 · 1 comment
Assignees
@at055612
Labels
bug f:auth Authentication, authorisation, TLS, security, etc.
Milestone
v7.4

Comments

@at055612
Copy link
Member

When you delete a doc, the document permission entries are left in the db. This then causes problems if a user with perms on that deleted doc is deleted (see #3662)
@at055612 at055612 added bug f:auth Authentication, authorisation, TLS, security, etc. labels May 17, 2024
@at055612 at055612 added this to the v7.4 milestone May 17, 2024
@at055612 at055612 self-assigned this May 17, 2024
at055612 added a commit that referenced this issue May 21, 2024
@at055612
gh-4278 Make doc delete also delete perms
b81da87 
Also make copy/move check for ownership in None/Destination/Combined
perm modes.
@at055612 at055612 mentioned this issue May 21, 2024
Closed
at055612 added a commit that referenced this issue May 22, 2024
@at055612
gh-4278 Del perms for deleted proc filters
031d7d0 
Add DB mig to purge orphaned doc perms.
WIP adding test for mig
Change the addPermission method to use tryCreate
at055612 added a commit that referenced this issue May 28, 2024
@at055612
gh-4278 Get cross module test working
e0b6c0c
at055612 added a commit that referenced this issue May 29, 2024
@at055612
gh-4278 Fix stack overflow in JooqUtil
d238e82
at055612 added a commit that referenced this issue May 29, 2024
@at055612
gh-4278 Improve migration test assertions
2128533
at055612 added a commit that referenced this issue May 29, 2024
@at055612
gh-4278 Fix CS
e4af0c5
at055612 added a commit that referenced this issue May 29, 2024
@at055612
gh-4278 Refactor the migration test framework
bc08765
at055612 added a commit that referenced this issue May 29, 2024
@at055612
gh-4278 Change cross mod tests to clear test db first
0e45a1b
at055612 added a commit that referenced this issue May 31, 2024
@at055612
gh-4278 Change DbTestUtil to re-create shared db if needed
9a62d5f
at055612 added a commit that referenced this issue Jun 6, 2024
@at055612
gh-4278 Attempt to fix failing mig test
fc83371
at055612 added a commit that referenced this issue Jun 6, 2024
@at055612
gh-4278 Fix mig test
f62da6e
@at055612 at055612 mentioned this issue Jun 6, 2024
Merged
at055612 added a commit that referenced this issue Jun 6, 2024
@at055612
Merge branch '7.5' into gh-4278-doc-delete-perms
b9135ff
at055612 added a commit that referenced this issue Jun 13, 2024
@at055612
Merge pull request #4310 from gchq/gh-4278-doc-delete-perms
5252429 
PR for #4278 - Deleting a doc doesn't delete the doc_permission records for it
@at055612
Copy link
Member Author

Fixed in > 7.5-beta.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@at055612 at055612

Labels
bug f:auth Authentication, authorisation, TLS, security, etc.
Projects
None yet
Milestone
v7.4
Development

No branches or pull requests
1 participant
@at055612