Grafana #333
Merged
Grafana #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
daisycrego
commented
Apr 9, 2020
•
daisycrego
commented
- Fix issue where after a new GFConfig is posted, all of the existing config info isn't passed in the context, so the page appears empty.
- Fix issue where new postgres datasource was not being given the same name used by add_panel in the grafana API - the result was that all of the panels were being created but the datasource wasn't configured correctly.
- Change the name of a test in the ag_data module which is failing so that it won't be run. Backend is putting in a PR soon to resolve this but for now this will fix it.
Frontend team
Frontend team
…atasource is configured BEFORE grafana dashboard(s) are created. This is why the datasource isn't being set up properly.
…en the page reloads - was missing some of the config data.
… name of the current postgres db (was being set to 'Datasource') so that add_panel will correctly associate the new panels with the datasource.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.