Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ctrl + enter to .com #135

Closed
Monirzadeh opened this issue Mar 4, 2020 · 6 comments
Closed

add ctrl + enter to .com #135

Monirzadeh opened this issue Mar 4, 2020 · 6 comments

Comments

@Monirzadeh
Copy link

please add ctrl + enter to add .com at in Vomnibar like browser address bar

@gdh1995
Copy link
Owner

gdh1995 commented Mar 4, 2020

If www. + “the query word” + .com is a domain, then Vomnibar can auto select it now. Is it not enough?

Ctrl+Enter has been used to force Vimium C to open selected item in a new tab.

@Monirzadeh
Copy link
Author

Monirzadeh commented Mar 4, 2020

no i thinks it is better to be like default browser Address bar behavior
it is my personal though about this function

  1. i usually handle open in this tab or new tab with o and t (i decide about that before open Vomnibar)
  2. i think ctrl + enter for open in new tab not use so frequently (you can replace that with ctrl + shift + enter)
  3. you should type at the least 4 unnecessary character (.com) to open a new a website.
  4. i think open a new website with type address and press ctrl + enter is so familiar than current behavior

@gdh1995
Copy link
Owner

gdh1995 commented Mar 5, 2020

Do you often visit a new website, which you have never visited before?

The last comment of mine means, currently, if the wanted website has been visited on your current browser, then Vimium C will know that "your query is a hostname of the website", and then show the whole hostname as the first suggestion item, so Enter will be enough.

@Monirzadeh
Copy link
Author

Monirzadeh commented Mar 6, 2020

can you add this as check mark option?
Update: if i can remap this to different keybinding is so good (i use alt + enter for launch other program on my system) for example i can modify shortcut on Vomnibar too.

gdh1995 added a commit that referenced this issue Mar 6, 2020
@gdh1995
Copy link
Owner

gdh1995 commented Mar 11, 2020

Hello, here's a test version in which Vomnibar uses Alt+Enter to auto complete www. and .com:
vimium_c-1.80.3-chrome-0ecf497.zip; vimium_c-1.80.3-firefox-0ecf497.zip.

Install:

  • unzip the files into an empty folder
  • if on Chrome, open chrome://extensions/ and enable the "developer mode"
  • if on Firefox, open about:debugging#/runtime/this-firefox manually
  • click the "load extension" button and select the extension folder or manifest.json

Extended usages: if you want to use Ctrl+Enter to do auto completing, you may add these to "Custom key mappings" on Vimium C Options page:

mapkey <c-enter:o> <a-enter>
mapkey <c-s-enter:o> <c-enter>

And then Ctrl-Enter will do auto completing, and Ctrl+Shift+Enter will force to open URLs in a new tab.

@Monirzadeh
Copy link
Author

thanks it is work fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants