Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cant add or update printer - save button greyed out and disabled - Display icon/text when app is locked #357

Closed
dan-glass opened this issue Jul 31, 2020 · 14 comments
Labels
enhancement New feature or request
Milestone

Comments

@dan-glass
Copy link

Since upgrading to the latest iOS version 3.5 the "save" button on the "Printer Details" screen remains greyed out no matter what is entered:

  • photo or api key string
  • http / https
  • enter port number in url
  • ip or host name
  • username valid or missing

The printers entered before upgrading work, but they cannot be modified.

(NOTE: The "scan" function doesn't find anything, so I was not able to test whether that would cause the save button to be enabled)

@dan-glass
Copy link
Author

dan-glass commented Jul 31, 2020

As a workaround. deleting app and settings, and reinstalling fixes the issue.

@kylerw
Copy link

kylerw commented Aug 12, 2021

I am experiencing the same thing

@gdombiak
Copy link
Owner

Hey @kylerw ,

Could you share screenshots so I may see what is going on? BTW, after you completed required fields (top 3), let me know if save button is enabled after you tap on any other part of the screen.

Thanks,
Gaston

@Xalior
Copy link

Xalior commented Aug 29, 2021

I too am getting this, and removing and reinstalling the app does not let me add a new printer. I also cannot delete my old printer, or disable iCloud syncing, meaning new installs of the app contain my old printer. To be clear I don't want to remove my old printer, I just want to add a second new printer -- but tried to remove the old one as a debugging step. Have tried to add via App API, OctoPrintEverywhere, and deprecated Global API, on two different iPhones, and the problem is always the same - save button never activated, so could not create new printer.

@gdombiak
Copy link
Owner

Hi @Xalior, sorry to hear the save button is putting up a fight. No need to delete a printer or reinstall the app to make this work. Could you do a simple test to see if this works? Once you completed all required fields (make sure you have a name, hostname and api key if you are using app key or global api key) then tap with the finger on any other field so your last field loses focus. Let me know if save button is enabled after this.

It would help me if you can tell me the exact steps you followed (maybe take a screenshot for each step) so I can reproduce this problem and see how I can fix it.

Thanks,
Gaston

@Xalior
Copy link

Xalior commented Aug 29, 2021

Pick Local (App Key) Auth:
15DCFE25-538C-43FF-B6C6-95FBE1D79247
Pick my Printer from the "scan" button:
E2A28F9B-046E-47FD-AD62-9088ACF0AAB5
Enter username, have even tried creating different user in octoprint:
F70CC0EA-5D19-4B3B-A770-A016C86EF157
Enter password, same credentials work fron from browser:
F95B9D70-9316-47A2-AE56-0ACB684F2581

Have tried clicking out of password box, onto other widgets at this point, tried toggling the switches for camera, tried tapping into the empty space in the UI layout, tried tapping the disabled save button, nothing progresses out of this screen except "Cancel".

@Xalior
Copy link

Xalior commented Aug 29, 2021

And, to confirm, the printer connection dialog box does contain correct, sane, details from the Scan...
53CD5D1A-4C9F-4B31-867B-339C3531CE7F

@gdombiak
Copy link
Owner

Hi @Xalior,

Thanks for sharing this great info. In this case, I see that you are using "Application Key" for adding a printer. The save button is disabled until you clicked on the Request button at the bottom and from OctoPrint you approved the request to give OctoPod an application Key.

However, in your screenshots I see that the Request button is also disabled. Since you completed the name of the printer and the URL address, the only reason to have that button disabled is that the app is locked. In OctoPod, could you go to Settings -> Security and make sure that Lock read-only mode is disabled?

Gaston

@Xalior
Copy link

Xalior commented Aug 29, 2021 via email

@gdombiak
Copy link
Owner

Excellent!! This tells me that I should show some indicator that the app is locked!!! The lock is handy when you are using Apple TV and want to lock print controls or if you handle the phone to someone and you do not want them to mess with your print job.

@gdombiak gdombiak added this to the 3.13 milestone Aug 29, 2021
@gdombiak gdombiak changed the title Cant add or update printer - save button greyed out and disabled Cant add or update printer - save button greyed out and disabled - Display icon/text when app is locked Aug 29, 2021
@gdombiak gdombiak added the enhancement New feature or request label Aug 29, 2021
@Xalior
Copy link

Xalior commented Aug 29, 2021 via email

@gdombiak
Copy link
Owner

How about this idea? I replaced the + button and the Save button for a lock

Simulator Screen Shot - iPhone 8 - 2021-08-29 at 14 02 49

Simulator Screen Shot - iPhone 8 - 2021-08-29 at 14 02 54

@Xalior
Copy link

Xalior commented Aug 29, 2021 via email

@gdombiak
Copy link
Owner

Excellent. Will go with this then for the next release. Thanks @Xalior for the feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants