Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with 2.5.0.beta4 #64

Closed
aaronpk opened this issue May 18, 2020 · 4 comments
Closed

Does not work with 2.5.0.beta4 #64

aaronpk opened this issue May 18, 2020 · 4 comments

Comments

@aaronpk
Copy link

aaronpk commented May 18, 2020

I upgraded from 2.5.0.beta2 to 2.5.0.beta4 today and this plugin caused the entire forum to break due to a JS error in this plugin.

The error in the console is unfortunately not very helpful:

_ember_jquery-3a388c5a0562670ed1eea762f12e041d92b4a418316d3f9f83e793d3ba6be5d7.js:4060 jQuery.Deferred exception: Cannot read property 'find' of undefined TypeError: Cannot read property 'find' of undefined
    at t.postFor (https://forum.ohmydollar.com/assets/plugins/retort-2b5f24e04afd560bb80ec54c5a13ff2bb05edb69aa06e7aa11af1be8275a56c0.js:1:1494)

I have to disable this plugin for now until this is fixed.

@gdpelican
Copy link
Owner

gdpelican commented May 18, 2020

👋 Looks like you may have a funky topic somewhere which doesn't have a postStream set properly.

Try updating to the latest version of retort, which should now account for this possibility :)

@aaronpk
Copy link
Author

aaronpk commented May 18, 2020

Is there a way to upgrade this plugin specifically? I just ran the regular ./launcher rebuild app which upgraded Discourse itself, and I assume would also grab the latest from this plugin.

@gdpelican
Copy link
Owner

gdpelican commented May 18, 2020 via email

@aaronpk
Copy link
Author

aaronpk commented May 18, 2020

hm okay, that's what I ran and when it came back online I was getting this error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants