Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 support? #10

Closed
gygitlab opened this issue Jun 3, 2020 · 4 comments
Closed

Python 3 support? #10

gygitlab opened this issue Jun 3, 2020 · 4 comments

Comments

@gygitlab
Copy link

gygitlab commented Jun 3, 2020

Alpine has recently got rid of Python2, which is needed for this (awesome) script.

While this is workaround-able for now I was wondering if there was ever any plans to support Python 3?

@gdraheim
Copy link
Owner

gdraheim commented Jun 3, 2020

The python3 compatibility had been intended from the start but it was missing actual testing.

I have updated the testsuite to allow for selection of a python3 interpreter, and the few errors are fixed now.

Please give it a test if it works for you.

@gygitlab
Copy link
Author

gygitlab commented Jul 2, 2020

Thanks @gdraheim. Had a check there and it still fails on this line - https://github.com/gdraheim/docker-copyedit/blob/master/docker-copyedit.py#L539

Looks like a missed except?

@gdraheim
Copy link
Owner

It did work on my disk but I did just notice that I had merged some patches that were created before modifying the master branch to Python3. The merge algorithm did somehow manage to revert one of the "except" usages. It is fixed now, thank's for checking that.

@gdraheim
Copy link
Owner

I have converted the source code to run with Python 3 by default. That includes the testsuite and I have added type hints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants