New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature - attached cdroms #99

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@gambol99
Contributor

gambol99 commented Jun 5, 2015

  • added the insert_cdrom into the orchestrator

gambol99 and others added some commits Jun 5, 2015

- added the schama for cdrom in the vm section
- added the insert_cdrom into the orchestrator
Merge pull request #1 from secureweb/rj/schema_update
added cdrom existance to tests
@ajlanghorn

This comment has been minimized.

Contributor

ajlanghorn commented Jun 11, 2015

@gambol99 I like this change, but I think it would be in a better position to merge if the commits were structured and had commit messages explaining the changes. We like to follow the convention that @annashipman sets out in this blog post.

@alexmuller

This comment has been minimized.

Contributor

alexmuller commented Jul 2, 2015

I think this depends on gds-operations/vcloud-core#169.

@mattbostock

This comment has been minimized.

Contributor

mattbostock commented Jul 20, 2015

Closing for now pending an update to gds-operations/vcloud-core#169.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment