Skip to content
This repository has been archived by the owner. It is now read-only.

feature - attached cdroms #99

Closed
wants to merge 3 commits into from
Closed

feature - attached cdroms #99

wants to merge 3 commits into from

Conversation

@gambol99
Copy link
Contributor

@gambol99 gambol99 commented Jun 5, 2015

  • added the insert_cdrom into the orchestrator
gambol99 and others added 3 commits Jun 5, 2015
- added the insert_cdrom into the orchestrator
added cdrom existance to tests
@ajlanghorn
Copy link
Contributor

@ajlanghorn ajlanghorn commented Jun 11, 2015

@gambol99 I like this change, but I think it would be in a better position to merge if the commits were structured and had commit messages explaining the changes. We like to follow the convention that @annashipman sets out in this blog post.

@alexmuller
Copy link
Contributor

@alexmuller alexmuller commented Jul 2, 2015

I think this depends on gds-operations/vcloud-core#169.

@mattbostock
Copy link
Contributor

@mattbostock mattbostock commented Jul 20, 2015

Closing for now pending an update to gds-operations/vcloud-core#169.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants