Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify brexit using topojson #117

Merged
merged 5 commits into from
Dec 1, 2020
Merged

Conversation

ljwolf
Copy link
Member

@ljwolf ljwolf commented Dec 1, 2020

This needs to swap out for `../data/simple_brexit.shp' in the datasets.

Also, stupidly, I think we should call this just "brexit.shp" and remove the kinds of "clean" or "simple" from our processed datasets.

@darribas
Copy link
Member

darribas commented Dec 1, 2020

OK @ljwolf I've given it a pass. A few changes:

  • PR now has Ch. 6 and 7 running off the new, simplified data
  • Cleaning notebook has a bit more verbose and links to the datasets
  • I've swapped simple_brexit for local_authority_districts which is what it represents (Brexit data is read separately)
  • I've saved the simplified geoms as a GeoJSON, not a shapefile so they're more easily linkable over the web

I think this is good to merge afaik

@ljwolf ljwolf merged commit 85621d1 into gdsbook:master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants