Merge pull request #2680 from gdsfactory/better_import_ports

better import gds and ports

gdsfactory/add_ports.py

@@ -74,7 +74,7 @@ def add_ports_from_markers_center(
     tol: float = 0.1,
     pin_extra_width: float = 0.0,
     min_pin_area_um2: float | None = None,
-    max_pin_area_um2: float = 150.0 * 150.0,
+    max_pin_area_um2: float | None = 150.0 * 150.0,
     skip_square_ports: bool = False,
     xcenter: float | None = None,
     ycenter: float | None = None,
@@ -100,8 +100,8 @@ def add_ports_from_markers_center(
         ycenter: for guessing orientation of rectangular ports.
         port_name_prefix: defaults to 'o' for optical and 'e' for electrical ports.
         port_type: type of port (optical, electrical ...).
-        short_ports: if the port is on the short side rather than the long side
-        auto_rename_ports:
+        short_ports: if the port is on the short side rather than the long side.
+        auto_rename_ports: if True renames ports to avoid duplicates.
         debug: if True prints ports that are skipped.
 
     For inside=False the port location is at the middle of the PIN
@@ -189,7 +189,7 @@ def add_ports_from_markers_center(
                 orientation = 0
                 width = dy
                 x = pxmax if inside else x
-            elif x < xc:  # west
+            else:  # west
                 orientation = 180
                 width = dy
                 x = pxmin if inside else x
@@ -198,7 +198,7 @@ def add_ports_from_markers_center(
                 orientation = 90
                 width = dx
                 y = pymax if inside else y
-            elif y < yc:  # south
+            else:  # south
                 orientation = 270
                 width = dx
                 y = pymin if inside else y
@@ -232,7 +232,7 @@ def add_ports_from_markers_center(
             x = pxmin if inside else x
 
         if orientation == -1:
-            raise ValueError(f"Unable to detector port at ({x}, {y})")
+            raise ValueError(f"Unable to detect port orientation at ({x}, {y})")
 
         x = snap_to_grid(x)
         y = snap_to_grid(y)

gdsfactory/read/import_gds.py

@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+from collections.abc import Callable
 from pathlib import Path
 
 import gdstk
@@ -23,6 +24,7 @@ def import_gds(
     keep_name_short: bool = False,
     unique_names: bool = True,
     max_name_length: int = 250,
+    post_process: Callable[..., None] | None = None,
     **kwargs,
 ) -> Component:
     """Returns a Component from a GDS file.
@@ -39,6 +41,7 @@ def import_gds(
         unique_names: appends $ with a number to the name if the cell name is on CACHE. \
                 This avoids name collisions when importing multiple times the same cell name.
         max_name_length: maximum length of the name.
+        post_process: function to post process the component after importing.
         kwargs: extra to add to component.info (polarization, wavelength ...).
     """
     gdspath = Path(gdsdir) / Path(gdspath) if gdsdir else Path(gdspath)
@@ -173,6 +176,8 @@ def import_gds(
     for k, v in kwargs.items():
         component.info[k] = v
     component.imported_gds = True
+    if post_process:
+        post_process(component)
     return component