Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better import gds and ports #2680

Merged
merged 1 commit into from
Apr 16, 2024
Merged

better import gds and ports #2680

merged 1 commit into from
Apr 16, 2024

Conversation

joamatab
Copy link
Contributor

  • simplify logic for import ports
  • add post_process to import_gds

@joamatab joamatab added the maintenance patch label Apr 16, 2024
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@0189bb8). Click here to learn what that means.
Report is 4 commits behind head on main.

Files Patch % Lines
gdsfactory/read/import_gds.py 33.33% 1 Missing and 1 partial ⚠️
gdsfactory/add_ports.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2680   +/-   ##
=======================================
  Coverage        ?   71.74%           
=======================================
  Files           ?      366           
  Lines           ?    23758           
  Branches        ?     3873           
=======================================
  Hits            ?    17046           
  Misses          ?     5583           
  Partials        ?     1129           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joamatab joamatab merged commit 993c2b4 into main Apr 16, 2024
13 of 15 checks passed
@joamatab joamatab deleted the better_import_ports branch April 16, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant