Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix kweb and set log level to warning instead of debug #1237

Merged
merged 4 commits into from Feb 5, 2023
Merged

fix kweb and set log level to warning instead of debug #1237

merged 4 commits into from Feb 5, 2023

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Feb 5, 2023

  • works with latest kweb
  • set log level to warning instead of debug

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 5, 2023

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.75%.

Quality metrics Before After Change
Complexity 6.27 ⭐ 6.22 ⭐ -0.05 👍
Method Length 65.81 🙂 65.43 🙂 -0.38 👍
Working memory 7.72 🙂 7.58 🙂 -0.14 👍
Quality 65.99% 🙂 66.74% 🙂 0.75% 👍
Other metrics Before After Change
Lines 2472 2486 14
Changed files Quality Before Quality After Quality Change
gdsfactory/component.py 65.62% 🙂 65.58% 🙂 -0.04% 👎
gdsfactory/config.py 70.32% 🙂 78.86% ⭐ 8.54% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
gdsfactory/component.py Component._write_library 20 😞 356 ⛔ 18 ⛔ 23.01% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
gdsfactory/component.py flatten_invalid_refs_recursive 20 😞 325 ⛔ 27.26% 😞 Refactor to reduce nesting. Try splitting into smaller methods
gdsfactory/component.py Component.plot_holoviews 14 🙂 475 ⛔ 12 😞 33.50% 😞 Try splitting into smaller methods. Extract out complex expressions
gdsfactory/component.py Component.add_polygon 18 🙂 282 ⛔ 12 😞 33.79% 😞 Try splitting into smaller methods. Extract out complex expressions
gdsfactory/component.py Component.remap_layers 29 😞 186 😞 11 😞 34.24% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Feb 5, 2023

Codecov Report

Merging #1237 (53e8f0a) into main (c71e1e5) will decrease coverage by 0.02%.
The diff coverage is 36.36%.

❗ Current head 53e8f0a differs from pull request most recent head bc383cb. Consider uploading reports for the commit bc383cb to get more accurate results

@@            Coverage Diff             @@
##             main    #1237      +/-   ##
==========================================
- Coverage   68.60%   68.58%   -0.02%     
==========================================
  Files         354      354              
  Lines       21057    21068      +11     
  Branches     3033     3034       +1     
==========================================
+ Hits        14446    14450       +4     
- Misses       5757     5764       +7     
  Partials      854      854              
Impacted Files Coverage Δ
gdsfactory/component.py 66.56% <0.00%> (-0.14%) ⬇️
gdsfactory/config.py 68.04% <44.44%> (-2.42%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joamatab joamatab merged commit bdd5c0d into main Feb 5, 2023
@joamatab joamatab deleted the 633b branch February 5, 2023 19:56
simbilod pushed a commit to simbilod/gdsfactory that referenced this pull request Mar 2, 2023
fix kweb and set log level to warning instead of debug

Former-commit-id: 4f590ff [formerly bdd5c0d]
Former-commit-id: 14caa2263a6ec2b7d154c03280734f66c08a1eb9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant