Skip to content

Commit

Permalink
Merge pull request gdsfactory#1237 from gdsfactory/633b
Browse files Browse the repository at this point in the history
fix kweb and set log level to warning instead of debug
  • Loading branch information
joamatab committed Feb 5, 2023
2 parents c71e1e5 + bc383cb commit bdd5c0d
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 4 deletions.
1 change: 1 addition & 0 deletions docs/notebooks/workflow/jupyter_notebooks.ipynb
Expand Up @@ -22,6 +22,7 @@
"import gdsfactory as gf\n",
"import kweb.server_jupyter as kj # requires `pip install gdsfactory[full]` or `pip install kweb`\n",
"\n",
"gf.config.set_log_level(\"DEBUG\")\n",
"kj.start()"
]
},
Expand Down
5 changes: 4 additions & 1 deletion gdsfactory/component.py
Expand Up @@ -1286,9 +1286,12 @@ def plot_jupyter(self):
layer_props = get_layer_views()
layer_props.to_lyp(filepath=lyp_path)

src = f"http://127.0.0.1:8000/gds?gds_file={escape(str(gdspath))}&layer_props={escape(str(lyp_path))}"
logger.debug(src)

if kj.jupyter_server and not os.environ.get("DOCS", False):
return IFrame(
src=f"http://127.0.0.1:8000/gds?file={escape(str(gdspath))}&layer_props={escape(str(layer_props))}",
src=src,
width=1400,
height=600,
)
Expand Down
19 changes: 17 additions & 2 deletions gdsfactory/config.py
Expand Up @@ -14,6 +14,7 @@

from __future__ import annotations

import sys
import io
import json
import os
Expand Down Expand Up @@ -45,8 +46,8 @@

MAX_NAME_LENGTH = 32

# logger.remove(0)
# logger.add(sink=sys.stderr, level="WARNING")
logger.remove()
logger.add(sink=sys.stderr, level="INFO")
logger.info(f"Load {str(module_path)!r} {__version__}")


Expand All @@ -58,6 +59,20 @@
)


def set_log_level(level: str, sink=sys.stderr) -> None:
"""Sets log level for gdsfactory.
Args:
level: ["DEBUG", "INFO", "WARNING", "ERROR"]
sink: defaults to standard error.
"""
log_levels = ["DEBUG", "INFO", "WARNING", "ERROR"]
if level not in log_levels:
raise ValueError(f"{level!r} not a valid log level {log_levels}")
logger.remove()
logger.add(sink=sink, level=level)


class Paths:
module = module_path
repo = repo_path
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Expand Up @@ -67,7 +67,7 @@ full = [
"scikit-learn",
"triangle",
"trimesh",
"kweb",
"kweb>=0.0.11,<0.1",
]
femwell = ["femwell"]
database = ["sqlalchemy", "sqlalchemy-utils"]
Expand Down

0 comments on commit bdd5c0d

Please sign in to comment.