Klayout Fill

[simbilod]

Combined @tvt173 and @sebastian-goeldi 's codes into a new .fill method for layouts

This whole dataprep thing is a bit of a gdsfactory/kfactory/klayout Frankenstein at the moment. Hopefully when I have more time I can look into KFactory more

[sourcery-ai]

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 2.82%.

Quality metrics	Before	After	Change
Complexity	1.34 ⭐	1.38 ⭐	0.04 👎
Method Length	54.19 ⭐	67.94 🙂	13.75 👎
Working memory	7.97 🙂	8.24 🙂	0.27 👎
Quality	71.15% 🙂	68.33% 🙂	-2.82% 👎

Other metrics	Before	After	Change
Lines	179	267	88

Changed files	Quality Before	Quality After	Quality Change
docs/notebooks/dataprep.py	51.28% 🙂	49.34% 😞	-1.94% 👎
gdsfactory/dataprep.py	81.24% ⭐	77.41% ⭐	-3.83% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
gdsfactory/dataprep.py	Layout.get_fill	3 ⭐	136 😞	9 🙂	63.53% 🙂	Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

[codecov]

Codecov Report

Merging #1484 (4e93ee8) into main (717dc63) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1484      +/-   ##
==========================================
- Coverage   68.48%   68.44%   -0.04%     
==========================================
  Files         374      374              
  Lines       22879    22892      +13     
  Branches     3318     3320       +2     
==========================================
  Hits        15668    15668              
- Misses       6279     6292      +13     
  Partials      932      932              

Impacted Files	Coverage Δ
gdsfactory/dataprep.py	0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[joamatab]

Awesome, thank you Simon,

we have a kfactory3 branch where we are trying to use kfactory as a backend for gdsfactory, to evaluate it vs klayout