Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fill docs #1486

Merged
merged 1 commit into from Mar 26, 2023
Merged

fix fill docs #1486

merged 1 commit into from Mar 26, 2023

Conversation

simbilod
Copy link
Collaborator

doc for #1484 was not pushed properly

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 26, 2023

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.09%.

Quality metrics Before After Change
Complexity 0.00 ⭐ 0.00 ⭐ 0.00
Method Length 387.00 ⛔ 381.00 ⛔ -6.00 👍
Working memory 11.00 😞 11.00 😞 0.00
Quality 49.34% 😞 49.43% 😞 0.09% 👍
Other metrics Before After Change
Lines 101 105 4
Changed files Quality Before Quality After Quality Change
docs/notebooks/dataprep.py 49.34% 😞 49.43% 😞 0.09% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Mar 26, 2023

Codecov Report

Merging #1486 (762af4f) into main (88a4a1d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1486   +/-   ##
=======================================
  Coverage   68.45%   68.45%           
=======================================
  Files         374      374           
  Lines       22893    22893           
  Branches     3320     3320           
=======================================
  Hits        15671    15671           
  Misses       6290     6290           
  Partials      932      932           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@simbilod simbilod merged commit 2cf79db into gdsfactory:main Mar 26, 2023
10 checks passed
@simbilod simbilod deleted the fill branch March 30, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant