Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test python3.7 #1745

Merged
merged 3 commits into from Jun 8, 2023
Merged

test python3.7 #1745

merged 3 commits into from Jun 8, 2023

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Jun 8, 2023

fixes #1744 by adding a bare bone tests of functionality

@joamatab joamatab mentioned this pull request Jun 8, 2023
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #1745 (8572af6) into main (ccc7766) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1745   +/-   ##
=======================================
  Coverage   68.74%   68.74%           
=======================================
  Files         373      373           
  Lines       23470    23471    +1     
  Branches     3399     3399           
=======================================
+ Hits        16135    16136    +1     
  Misses       6389     6389           
  Partials      946      946           
Impacted Files Coverage Δ
gdsfactory/config.py 58.37% <100.00%> (+0.21%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joamatab joamatab merged commit c35b75c into main Jun 8, 2023
9 checks passed
@joamatab joamatab deleted the python37 branch June 8, 2023 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bring 3.7 testing back?
1 participant