Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test python3.7 #1745

Merged
merged 3 commits into from Jun 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 15 additions & 0 deletions .github/workflows/test_code.yml
Expand Up @@ -75,6 +75,21 @@ jobs:
with:
token: ${{ secrets.CODECOV_TOKEN }}
fail_ci_if_error: false
test_code_python37:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: '3.7'
- name: Install dependencies
run: |
pip install -e .[full,dev] pre-commit
- name: Test with pytest
run: |
pytest gdsfactory/components
test_code_plugins:
runs-on: ${{ matrix.os }}
strategy:
Expand Down
2 changes: 1 addition & 1 deletion docs/CHANGELOG.md
@@ -1,4 +1,4 @@
# [CHANGELOG](https://keepachangelog.com/en/1.0.0/)
# [Changelog](https://keepachangelog.com/en/1.0.0/)

## [Unreleased](https://github.com/gdsfactory/gdsfactory/compare/v6.103.1...main)

Expand Down
2 changes: 1 addition & 1 deletion docs/contribution.md
Expand Up @@ -11,7 +11,7 @@ The recommended place to ask a question is on [GitHub Discussions](https://githu
You can fork the repo, work on a feature, and then create a Pull Request to merge your feature into the `main` branch.
This will benefit other project community members and make you famous :).

Take a look at the [open issues](https://github.com/gdsfactory/gdsfactory/issues) to find issues that interest you. Some issues are particularly suited for new contributors by the [good first issue label](https://github.com/gdsfactory/gdsfactory/labels/good first issue) where you could start out. These are well documented issues, that do not require a deep understanding of the internals of gdsfactory.
Take a look at the [open issues](https://github.com/gdsfactory/gdsfactory/issues) to find issues that interest you. Some issues are particularly suited for new contributors by the [good first issue label](https://github.com/gdsfactory/gdsfactory/labels/good_first_issue) where you could start out. These are well documented issues, that do not require a deep understanding of the internals of gdsfactory.

Here are some other ideas for possible contributions:

Expand Down
3 changes: 2 additions & 1 deletion gdsfactory/config.py
Expand Up @@ -18,7 +18,8 @@
import warnings
from pathlib import Path
from pprint import pprint
from typing import Any, Optional, Union, ClassVar, Literal, TYPE_CHECKING
from typing_extensions import Literal
from typing import Any, Optional, Union, ClassVar, TYPE_CHECKING

import loguru
from loguru import logger as logger
Expand Down