-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Obey stacklevel in warnings.warn
for loguru output
#2656
Obey stacklevel in warnings.warn
for loguru output
#2656
Conversation
Label error. Requires at least 1 of: breaking, bug, github_actions, documentation, dependencies, enhancement, feature, maintenance, security. Found: python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @nikosavola - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Docstrings: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2656 +/- ##
==========================================
- Coverage 71.79% 71.77% -0.02%
==========================================
Files 366 366
Lines 23754 23756 +2
Branches 3873 3874 +1
==========================================
- Hits 17053 17052 -1
- Misses 5576 5578 +2
- Partials 1125 1126 +1 ☔ View full report in Codecov by Sentry. |
As an example, these two statements are now both printed with the same linenumber in the same file
Loguru
Warnings
Additionally, disables using warnings.showwarnings and makes the gdsfactory defaults only print using loguru, closes #2588