Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use exclusively loguru for logging output but warnings.warn internally #2588

Closed
2 of 3 tasks
nikosavola opened this issue Mar 6, 2024 · 0 comments · Fixed by #2656
Closed
2 of 3 tasks

Use exclusively loguru for logging output but warnings.warn internally #2588

nikosavola opened this issue Mar 6, 2024 · 0 comments · Fixed by #2656
Labels
enhancement New feature or request

Comments

@nikosavola
Copy link
Member

nikosavola commented Mar 6, 2024

Is your feature request related to a problem? Please describe.
Continuing from #2451 (comment). As using warnings.warn seems to be chosen way but loguru is still used, it would be nice if only one of these were used for logging by default. Loguru is the nicer looking option and a dependency we have so that should be the choice.

I suggest handling printing the output with only loguru but keeping using warnings.warn for the warning category and exception support.

Describe the solution you'd like
The following subtasks should allow switching the default logger output to loguru without losing relevant information.

After these steps, I think we can disable the showwarning call found in

showwarning_(message, *args, **kwargs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant