5611

[joamatab]

• add python3.6 deprecation notice in the docs issue
• add edge_coupler, edge_coupler_array and edge_coupler_array_with_loopback
• add python3.10 tests

[sourcery-ai]

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics	Before	After	Change
Complexity	13.83 🙂	13.88 🙂	0.05 👎
Method Length	105.78 🙂	105.72 🙂	-0.06 👍
Working memory	14.81 😞	14.81 😞	0.00
Quality	46.21% 😞	46.21% 😞	0.00%

Other metrics	Before	After	Change
Lines	1319	1330	11

Changed files	Quality Before	Quality After	Quality Change
gdsfactory/components/init.py	29.00% 😞	29.00% 😞	0.00%
gdsfactory/components/grating_coupler_loss.py	63.04% 🙂	62.88% 🙂	-0.16% 👎
gdsfactory/components/pad_gsg.py	59.65% 🙂	60.85% 🙂	1.20% 👍
gdsfactory/components/pads_shorted.py	73.89% 🙂	73.89% 🙂	0.00%
gdsfactory/components/rectangle_with_slits.py	56.89% 🙂	56.89% 🙂	0.00%
gdsfactory/components/resistance_meander.py	32.88% 😞	32.88% 😞	0.00%
gdsfactory/components/resistance_sheet.py	57.86% 🙂	57.86% 🙂	0.00%
gdsfactory/components/ring.py	71.58% 🙂	71.58% 🙂	0.00%
gdsfactory/components/splitter_tree.py	20.47% ⛔	20.47% ⛔	0.00%

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
gdsfactory/components/splitter_tree.py	splitter_tree	57 ⛔	474 ⛔	20 ⛔	6.87% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
gdsfactory/components/resistance_meander.py	resistance_meander	13 🙂	416 ⛔	16 ⛔	29.49% 😞	Try splitting into smaller methods. Extract out complex expressions
gdsfactory/components/resistance_sheet.py	resistance_sheet	2 ⭐	184 😞	17 ⛔	47.70% 😞	Try splitting into smaller methods. Extract out complex expressions
gdsfactory/components/rectangle_with_slits.py	rectangle_with_slits	3 ⭐	151 😞	17 ⛔	49.84% 😞	Try splitting into smaller methods. Extract out complex expressions
gdsfactory/components/grating_coupler_loss.py	loss_deembedding_ch13_24	1 ⭐	187 😞	15 😞	50.56% 🙂	Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
5 Code Smells

No Coverage information
0.0% Duplication