Merge pull request #1339 from gkatev/codenav_fix_old_model_segv

codenav/goto_file: Fix use-after-free crash
geany · May 19, 2024 · 6e0cb58 · 6e0cb58
2 parents 51ed8e4 + adaceb6
commit 6e0cb58
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/codenav/src/goto_file.c b/codenav/src/goto_file.c
@@ -163,8 +163,11 @@ directory_check(GtkEntry* entry, GtkEntryCompletion* completion)
         if (old_model != NULL)
         {   /* Restore the no-sub-directory model */
             log_debug("Restoring old model!");
+
             gtk_entry_completion_set_model (completion, old_model);
+            g_object_unref(old_model);
             old_model = NULL;
+
             g_free(curr_dir);
             curr_dir = NULL;
         }
@@ -185,7 +188,10 @@ directory_check(GtkEntry* entry, GtkEntryCompletion* completion)
 
     /* Save the completion_mode for future restore. */
     if (old_model == NULL)
+    {
         old_model = gtk_entry_completion_get_model(completion);
+        g_object_ref(old_model);
+    }
 
     log_debug("New completion list!");