Skip to content

Commit

Permalink
Remove -Werror=aggregate-return from travis flags (#529)
Browse files Browse the repository at this point in the history
While in general one should avoid returning big structs for performance
reasons, it's no big problem for small structs and it can lead to more
readable code.

Having this check on for everything seems to be too strict - if someone
is returning big structs like crazy, someone will probably notice during
the review. Otherwise it's no problem.
  • Loading branch information
techee authored and frlan committed Feb 19, 2017
1 parent 4144a71 commit 8e511d1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .travis.yml
Expand Up @@ -125,7 +125,7 @@ before_install:

before_script:
# prepare for GP
- export CFLAGS="-g -O2 -Werror=pointer-arith -Werror=aggregate-return -Werror=implicit-function-declaration"
- export CFLAGS="-g -O2 -Werror=pointer-arith -Werror=implicit-function-declaration"

script:
- NOCONFIGURE=1 ./autogen.sh
Expand Down

0 comments on commit 8e511d1

Please sign in to comment.