Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workbench: Changing options are not saved #841

Closed
frlan opened this issue Apr 14, 2019 · 7 comments · Fixed by #868
Closed

workbench: Changing options are not saved #841

frlan opened this issue Apr 14, 2019 · 7 comments · Fixed by #868
Labels
enhancement plugin/workbench

Comments

@frlan
Copy link
Member

frlan commented Apr 14, 2019

When using the Tools->Workbench->Settings changed options are not saved to configuration file of workbench project
@frlan
Copy link
Member Author

frlan commented Apr 14, 2019

@LarsGit223 I think this is something for ;)

@lpaulsen93
Copy link
Contributor

@frlan: did you choose "Tools->Workbench->Save"? The settings are not saved automatically.

@frlan
Copy link
Member Author

frlan commented Apr 14, 2019

@LarsGit223 No I did not. Expectation for settings was, that it is saved automatically.

@lpaulsen93
Copy link
Contributor

Well, then everything works as-designed and it is not a bug. But you could change the label to "enhancement" if you like.

@frlan frlan added enhancement and removed bug labels Apr 14, 2019
@frlan
Copy link
Member Author

frlan commented Apr 14, 2019

Done. While unexpected behaviour is a bug for me ;)

@lpaulsen93
Copy link
Contributor

Done. While unexpected behaviour is a bug for me ;)

It is the expected behaviour (it works as implemented/expected by the author). But your expectations doesn't match the actual implementation ;-)

lpaulsen93 added a commit to lpaulsen93/geany-plugins that referenced this issue May 20, 2019
@lpaulsen93
workbench: save settings immediately
9e480a3 
After confirming changed settings with "OK" they will now immediately
be written back to the workbench file. Therefore the menu item
"Workbench / Save" became useless and has been removed. Closes geany#841.
@lpaulsen93 lpaulsen93 mentioned this issue May 20, 2019
Merged
lpaulsen93 added a commit to lpaulsen93/geany-plugins that referenced this issue Jun 23, 2019
@lpaulsen93
workbench: auto-save project on change
f1ae577 
This removes the item "Save project" from the popup menu and automatically
saves a project if something is changed (e.g. directory added/removed).

This also fixes some situations in which saving of the workbench file
was missing (e.g. a change in the workbench bookmarks). See geany#841.
@lpaulsen93 lpaulsen93 mentioned this issue Jun 23, 2019
Merged
@lpaulsen93
Copy link
Contributor

@frlan: I now also removed the option "Save project" and projects are also saved automatically if a workbench related project setting is changed. Also I fixed a little bug regarding this issue, see PR #877.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement plugin/workbench
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

workbench: save settings immediately lpaulsen93/geany-plugins
2 participants
@frlan @lpaulsen93