Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bookmark sidebar does not always match actual bookmarks #964

Closed
dbkaynor opened this issue Mar 25, 2020 · 2 comments
Closed

Bookmark sidebar does not always match actual bookmarks #964

dbkaynor opened this issue Mar 25, 2020 · 2 comments

Comments

@dbkaynor
Copy link

When clearing the bookmarks using the Documents/Remove Markers option the actual bookmarks are cleared but the sidebar list is not. Also sometimes the same bookmark gets listed multiple times in the sidebar list.
@eht16
Copy link
Member

eht16 commented Mar 28, 2020

Remove Markers just removes any markers, this can be also markers for search highlights and maybe more.
It is not intended that this option also clears the bookmark list.

Could you provide more details for the second problem? When exactly does it happen, steps to reproduce?

@dbkaynor
Copy link
Author

dbkaynor commented May 3, 2020

The issue with bookmarks gets listed multiple times in the sidebar list only happens when the numbed bookmark plugin is installed. I will provide more info when I am able to get it.

@dbkaynor dbkaynor closed this as completed May 3, 2020
eht16 added a commit to eht16/geany-plugins that referenced this issue Nov 29, 2020
@eht16
Addons: Bookmarks: Prevent duplicating bookmarks when editing line
162822f 
For some filetype (more specifically some Scintilla lexers) it might
happen that an event with modificationType SC_MOD_CHANGEMARKER is
sent and so the current line is added as bookmark again.
To avoid this, check if the current line has already a bookmark and
update it in this case.

Might be related to geany#964.
@eht16 eht16 mentioned this issue Nov 29, 2020
Merged
eht16 added a commit to eht16/geany-plugins that referenced this issue Nov 29, 2020
@eht16
Addons: Bookmarks: Prevent duplicating bookmarks when editing line
aa55ffa 
For some filetypes (more specifically some Scintilla lexers) it might
happen that an event with modificationType SC_MOD_CHANGEMARKER is
sent and so the current line is added as bookmark again.
To avoid this, check if the current line has already a bookmark and
update it in this case.

Might be related to geany#964.
eht16 added a commit to eht16/geany-plugins that referenced this issue Sep 17, 2022
@eht16
Addons: Bookmarks: Prevent duplicating bookmarks when editing line
bf574c8 
For some filetypes (more specifically some Scintilla lexers) it might
happen that an event with modificationType SC_MOD_CHANGEMARKER is
sent and so the current line is added as bookmark again.
To avoid this, check if the current line has already a bookmark and
update it in this case.

Might be related to geany#964.
@hg2581 hg2581 mentioned this issue May 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eht16 @dbkaynor