Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PrettyPrinter: Don't try to free const gchar* input_buffer #1024

Merged
merged 1 commit into from Nov 8, 2020
Merged

PrettyPrinter: Don't try to free const gchar* input_buffer #1024

merged 1 commit into from Nov 8, 2020

Conversation

frlan
Copy link
Member

@frlan frlan commented Nov 8, 2020

No description provided.

b4n
b4n requested changes Nov 8, 2020
View reviewed changes
Copy link
Member

@b4n b4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is not freeing input_buffer which should be freed, but that the input_buffer variable shouldn't be const (since 3fad128). The change you propose would lead to leaking quite a lot of memory.

@frlan
Copy link
Member Author

frlan commented Nov 8, 2020

@b4n True. Will update it

@frlan frlan force-pushed the enhancement/prettyprinter/compiler-warning branch from 31285dc to 2a8969f Compare November 8, 2020 16:17
b4n
b4n approved these changes Nov 8, 2020
View reviewed changes
Copy link
Member

@b4n b4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frlan frlan merged commit 3864559 into geany:master Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b4n b4n b4n approved these changes

Assignees
No one assigned
Labels
plugin/pretty-printer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@frlan @b4n