Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Organizer: Use system trash for file/folder removal #1125

Merged
merged 1 commit into from Jan 30, 2022

Conversation

xiota
Copy link
Contributor

@xiota xiota commented Oct 24, 2021

Use system trash when removing files/folders in Project Organizer.

Copy link
Member

@techee techee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks.

@xiota
Copy link
Contributor Author

xiota commented Nov 3, 2021

@eht16 Out of curiosity, is GeanyLua not currently building holding other PRs back? Thanks.

@eht16
Copy link
Member

eht16 commented Nov 7, 2021

@eht16 Out of curiosity, is GeanyLua not currently building holding other PRs back? Thanks.

At least not technically.
GeanyLua currently breaks all G-P CI pipelines. Though other PRs, such as this, can be merged anyway even if the pipeline does not succeed.

@xiota
Copy link
Contributor Author

xiota commented Nov 7, 2021

@eht16 The change was approved. So was wondering what needs to happen before merging. The CI pipeline being blocked by GeanyLua seemed like a potential issue.

@eht16 eht16 merged commit cc23333 into geany:master Jan 30, 2022
@xiota xiota deleted the pr-prjorg-trash branch October 12, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants