Markdown: Modify replace_all to avoid infinite loop #1128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elextr
reviewed
Oct 29, 2021
|
There is a g_string_replace() that does replace all, but its very new, probably should keep this for now. |
|
Looks ok to me, but I don't build or use markdown plugin, so I won't test it. |
Requires glib 2.68... Not available for Ubuntu LTS 18.04 (glib 2.54) or 20.04 (glib 2.64). |
|
Yeah, thats why I called it "very new". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies
replace_allto avoid the infinite loop. In each iteration,replace_allsearches forneedlestarting from the beginning ofhaystack. Ifreplacementcontainsneedle, the result is an infinite loop. To prevent this from happening,replace_allshould continue searching forneedlefrom the end of the previousreplacement.Resolves #936.