Use standard gettext, following Geany core. #1183
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standard gettext should be used over glib's glue these days. AM_GLIB_GNU_GETTEXT and glib-gettextize are deprecated. This helps possible meson build (no concrete plans yet) as well as working with intltool is harder over there. gettext, on the other hand, is supported out of the box in meson. Beware, autopoint is a new dependency when building from git, should not affect tarballs. Also, it's already required by Geany core. Additionally, autogen.sh follows Geany's autogen.sh more closely, allowing for out-of-tree builds.
Requires running update-po to fix the build.
eht16
reviewed
Sep 4, 2022
| GETTEXT_PACKAGE=geany-plugins | ||
| AC_SUBST(GETTEXT_PACKAGE) | ||
| AC_DEFINE_UNQUOTED( | ||
| [GETTEXT_PACKAGE], | ||
| o [GETTEXT_PACKAGE], |
There was a problem hiding this comment.
Is this a typo or some special M4 syntax?
eht16
reviewed
Sep 4, 2022
| @@ -16,9 +16,11 @@ AM_PROG_CC_C_O | |||
| AC_DISABLE_STATIC | |||
| AC_PROG_LIBTOOL | |||
|
|
|||
| dnl i18n | |||
| IT_PROG_INTLTOOL([0.35.0]) | |||
| GP_I18N | |||
There was a problem hiding this comment.
If we don't call GP_I18N here anymore, couldn't we remove build/i18n.m4 completely?
If so, we probably need to declare LOCALEDIR here or still use GP_I18N.
|
Apart from the comments above, LGBI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard gettext should be used over glib's glue these days.
AM_GLIB_GNU_GETTEXT and glib-gettextize are deprecated. This helps
possible meson build (no concrete plans yet) as well as working with
intltool is harder over there. gettext, on the other hand, is supported
out of the box in meson.
Beware, autopoint is a new dependency when building from git,
should not affect tarballs. Also, it's already required by Geany core.
Additionally, autogen.sh follows Geany's autogen.sh more closely,
allowing for out-of-tree builds.