Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pt_BR.po #1260

Closed
wants to merge 1 commit into from
Closed

Update pt_BR.po #1260

wants to merge 1 commit into from

Conversation

liomarhora
Copy link

No description provided.

@eht16
Copy link
Member

eht16 commented Aug 5, 2023

Are these changes intended?

@liomarhora
Copy link
Author

Are these changes intended?

Yes, I'm removed the old library devhelp2.

@eht16
Copy link
Member

eht16 commented Aug 6, 2023

I don't get it.
Currently, there is no Devhelp in GIT master. So, strictly the *.po files should be updated to remove the previous translations.

But since you are already about to re-add the plugin, updating the translation files would be done best after your changes from #1242 have been merged.

So, why do you want to comment one (to me random) translation string in GIT master from the not yet available Devhelp plugin?

@elextr
Copy link
Member

elextr commented Aug 6, 2023

Won't it be commented automatically anyway if devhelp is still missing when the message files are re-merged before next release?

IMO leave it to the tools.

@liomarhora
Copy link
Author

I must have duplicated it due to using two computers
I use 2 PCs to update the plugin.
It seems to me that I created 2 forks for the same plugin.
should I keep both or migrate to the one with the highest number of commits?

@eht16
Copy link
Member

eht16 commented Aug 7, 2023

I suggest to simply close this PR and focus on #1242 which has the same changes.

Edit: above was the wrong comment with the correct conclusion :).
We don't need the changes of this PR and as @elextr said above, the gettext tools will update the translation file at somepoint after the Devhelp plugin has been added again and then either update the translation string changed here or just remove it.
There is no need to manually fiddle around with this single translation string here.

@eht16 eht16 closed this Aug 7, 2023
@liomarhora
Copy link
Author

Sugiro simplesmente fechar este PR e focar no nº 1242 , que tem as mesmas alterações.
Ok.

@liomarhora liomarhora deleted the patch-1 branch August 7, 2023 21:13
@liomarhora
Copy link
Author

have you tested the plugin in your Geany IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants