debugger: Fix internal EnvTree state after plugin reload #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the module is resident, the global variables won't get reinitialized automatically when the plugin is reloaded, so reinitialize them explicitly. This is especially important for the `empty_row` variable as not re-initializing it will lead to a double-free, and possibly a crash.
|
@cesspit If you can find a minute you could also give this a look :) |
|
+1 |
Those should not cause any problem in real situations, but resetting them properly is safer as it doesn't depend on a very specific sequence of events.
b4n
added a commit
that referenced
this pull request
Jul 4, 2015
debugger: Fix crash after plugin reload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the module is resident, the global variables won't get reinitialized
automatically when the plugin is reloaded, so reinitialize them
explicitly.
This is especially important for the
empty_rowvariable as notre-initializing it will lead to a double-free, and possibly a crash.