Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spellcheck: Use <> to include Geany headers #393

Merged
merged 1 commit into from Mar 8, 2016

Conversation

b4n
Copy link
Member

@b4n b4n commented Mar 7, 2016

Apparently some older versions of cppcheck get stupid when passed extra
flags like -D, so try and make them happy by showing them those are
library (system-wide) headers rather than application (local) ones.

@b4n
Copy link
Member Author

b4n commented Mar 7, 2016

Err, there's a typo in the plugin's name, funny for a spellcheck-related fix :)

Apparently some older versions of cppcheck get stupid when passed extra
flags like `-D`, so try and make them happy by showing them those are
library (system-wide) headers rather than application (local) ones.
@b4n b4n force-pushed the spellcheck/include-style branch from 3fdeed2 to 57827d2 Compare March 7, 2016 19:08
@b4n
Copy link
Member Author

b4n commented Mar 7, 2016

fixed the typo

@b4n b4n assigned eht16 Mar 7, 2016
@b4n b4n mentioned this pull request Mar 7, 2016
9 tasks
@eht16
Copy link
Member

eht16 commented Mar 8, 2016

I'm happy with merging this.
Still being curious: where is the typo you mentioned? In the diff? In the title of this PR, then it is not fixed :).

And more related to the changes themselves: shouldn't other plugins which use #include "geanyplugin.h" also be affected? Or is there something special in SpellCheck from cppcheck's POV?

@b4n b4n changed the title spellecheck: Use <> to include Geany headers spellcheck: Use <> to include Geany headers Mar 8, 2016
@b4n
Copy link
Member Author

b4n commented Mar 8, 2016

Still being curious: where is the typo you mentioned? In the diff? In the title of this PR, then it is not fixed :).

It was the commit message, but I forgot to update the title (which was autogenerated from the commit) :)

And more related to the changes themselves: shouldn't other plugins which use #include "geanyplugin.h" also be affected? Or is there something special in SpellCheck from cppcheck's POV?

Apparently other plugins are not affected, yet I can't really tell you why. All I can guess is that, as stated in the commit message, when you pass defines options to cppheck (-Dsomething) it starts requiring all "" headers to be found -- maybe it tries running a preprocessor or something in this case? As SpellCheck is the only plugin passing a -D option to cppcheck, it's the only one affected.

@b4n b4n merged commit 57827d2 into geany:master Mar 8, 2016
b4n added a commit that referenced this pull request Mar 8, 2016
spellcheck: Use <> to include Geany headers
@b4n b4n added this to the 1.27 milestone Mar 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants