Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automark: Don't try to get some selection if line is empty #514

Merged
merged 1 commit into from Jan 5, 2017

Conversation

frlan
Copy link
Member

@frlan frlan commented Jan 4, 2017

This PR should remove warnings like

(geany:7479): Geany-CRITICAL **: sci_get_contents_range: assertion 'start < end' failed

Backtrace befre:

Thread 1 "geany" hit Breakpoint 1, handler_log (domain=0x7ffff7b64da2 "Geany", level=G_LOG_LEVEL_CRITICAL, 
    msg=0x55555651f800 "sci_get_contents_range: assertion 'start < end' failed", data=0x0) at log.c:121
121	{
(gdb) bt
#0  handler_log (domain=0x7ffff7b64da2 "Geany", level=G_LOG_LEVEL_CRITICAL, 
    msg=0x55555651f800 "sci_get_contents_range: assertion 'start < end' failed", data=0x0) at log.c:121
#1  0x00007ffff52bd5c4 in g_logv () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2  0x00007ffff52bd7cf in g_log () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#3  0x00007ffff79bf94b in sci_get_contents_range (sci=sci@entry=0x555556373520, start=start@entry=11519, end=<optimized out>)
    at sciwrappers.c:990
#4  0x00007fffe5db8da8 in get_current_word (sci=0x555556373520) at automark.c:92
#5  automark (user_data=<optimized out>) at automark.c:117
#6  0x00007ffff52b66aa in g_main_context_dispatch () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#7  0x00007ffff52b6a60 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#8  0x00007ffff52b6d82 in g_main_loop_run () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#9  0x00007ffff7251cc5 in gtk_main () from /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#10 0x00007ffff79ad097 in main_lib (argc=<optimized out>, argv=<optimized out>) at libmain.c:1233
#11 0x00007ffff4cd12b1 in __libc_start_main () from /lib/x86_64-linux-gnu/libc.so.6
#12 0x000055555555478a in _start ()
(gdb) r

Copy link
Member

@b4n b4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frlan frlan merged commit b1ec041 into geany:master Jan 5, 2017
@frlan frlan deleted the enhancement/automark/prevent_warnings branch January 5, 2017 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants