Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prj_org != NULL check to fix project reload crash. #550

Closed
wants to merge 1 commit into from
Closed

Add prj_org != NULL check to fix project reload crash. #550

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 27, 2017

No description provided.

@ghost ghost mentioned this pull request Mar 28, 2017
Closed
@kugel-
Copy link
Member

kugel- commented Mar 31, 2017

This fix resolves the crash but the @techee has opened #555 as an alternative fix.

@techee
Copy link
Member

techee commented Apr 3, 2017

Sorry @ghost, I didn't notice your patch - I think it's fine to fix the crash alone. However, in #555 I added another sanity check now to avoid expanding incorrect paths if another project is opened immediately afterwards so I'd prefer if #555 could be applied instead of your patch.

@frlan
Copy link
Member

frlan commented Apr 8, 2017

As by @techee I will not apply this one for the moment.

@frlan frlan closed this Apr 8, 2017
@frlan
Copy link
Member

frlan commented Apr 8, 2017

But thanks for contributing. (I always forget to say it but even not merged PR are good support)

@codebrainz codebrainz mentioned this pull request Jun 4, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
plugin/projectorganizer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kugel- @techee @frlan @codebrainz