Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-changebar: Fix spurious line wrapping #564

Merged
merged 1 commit into from Apr 30, 2017

Conversation

vfaronov
Copy link
Contributor

@vfaronov vfaronov commented Apr 19, 2017

This fixes #567 for me, but I haven’t investigated exactly why this extra pixel is necessary, so I may be doing something wrong.

@frlan frlan requested a review from b4n April 29, 2017 11:19
Copy link
Member

@b4n b4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I don't get why this extra pixel would be needed without looking at Scintilla's code (which is kind of scary in this area), but the change is innocent enough and indeed fixes the issue for me too.
Good job 👍

@b4n
Copy link
Member

b4n commented Apr 30, 2017

And thanks for also thinking of adding a comprehensive comment on the magic +2 :)

@b4n b4n merged commit ad5ca5e into geany:master Apr 30, 2017
b4n added a commit that referenced this pull request Apr 30, 2017
git-changebar: Fix spurious line wrapping
@vfaronov vfaronov deleted the git-changebar-line-wrap branch April 30, 2017 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

git-changebar: Lines are wrapped when they don’t need to be
2 participants