pretty-printer: added saving and loading of preferences in/from a file. Fixes #494. #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thannoy
reviewed
Jun 17, 2017
pretty-printer/src/ConfigUI.c
Outdated
| else ppo->newLineChars = "\r\n"; | ||
| if (ppo->newLineChars != NULL) | ||
| { | ||
| g_free ((gpointer)ppo->newLineChars); |
There was a problem hiding this comment.
(minor) freeing a NULL pointer is perfectly legal. There is no need to test nullity, you can use g_free unconditionally here. (see https://developer.gnome.org/glib/stable/glib-Memory-Allocation.html#g-free)
Thannoy
reviewed
Jun 17, 2017
pretty-printer/src/ConfigUI.c
Outdated
| { | ||
| if (ppo->newLineChars != NULL ) | ||
| { | ||
| g_free ((gpointer)ppo->newLineChars); |
There was a problem hiding this comment.
(minor) same as above, you can use g_free unconditionally here
|
@Thannoy: thanks, did not know that. Just fixed it. |
|
Thanks for the PR. I will postpone it for 1.32 as currently there is no active maintainer for the plugin and I will not be able to do proper review until release |
|
👍 Fine for me. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request implements saving and loading of the pretty-printer plugin preferences. In the current version pretty-printer simply does not save the preferences to a file so all changes to the preferences get lost after closing geany.
The code for saving and loading the preferences is adopted from the overview plugin. The config file is named
geany/plugins/pretty-printer/prefs.conf.