New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workbench #598
Workbench #598
Changes from 1 commit
87b6d5c
4f5563d
770bfbc
b5b9cc2
2890905
3a47865
1cb06e1
dc219bd
3e2c7c7
b93eb75
b4cd244
008194a
4104285
b77f73a
389d827
7c66abf
fc99613
76d1253
66acbb9
7a9d154
8211ea8
d921260
74a634c
e39fea5
556f03f
549cd76
4d1c33d
4451157
61b0991
aff5cb9
8846193
dc98c37
465d9ae
bbe27e8
6ae0a3b
36fbfb6
0212100
13d3b70
cace73d
7574055
00b8941
109b8d0
e0de82b
daba342
36f8d84
65a5e5b
4c92297
fa97eaa
d6993d8
4ae4580
c20dc6f
6560f6b
bfa8662
f67c194
6aa0b70
c24fe00
9c90b80
be25bad
fa35023
eaa9265
316e11f
6d8d2d8
145476a
ed27167
039d43f
8409530
48c08cc
2e09b55
6199a6b
f7ba628
bea0a0f
01a8dfa
d19678c
9fecc2c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -162,39 +162,39 @@ gboolean menu_init(void) | |
gtk_widget_show(menu_data.root_item); | ||
|
||
/* Create new menu item "New Workbench" */ | ||
menu_data.item_new = gtk_menu_item_new_with_mnemonic(_("New")); | ||
menu_data.item_new = gtk_menu_item_new_with_mnemonic(_("_New")); | ||
gtk_widget_show(menu_data.item_new); | ||
gtk_menu_append(GTK_MENU (menu_data.menu), menu_data.item_new); | ||
g_signal_connect(menu_data.item_new, "activate", | ||
G_CALLBACK(item_new_workbench_activate_cb), NULL); | ||
geany_plugin_set_data(wb_globals.geany_plugin, menu_data.item_new, NULL); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hum, there's something fishy here. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm...removed the calls. I do not remember exactly. Maybe copied from some place. I also thought I can use it to get the items destroyed on ending geany/the plugin. |
||
|
||
/* Create new menu item "Open Workbench" */ | ||
menu_data.item_open = gtk_menu_item_new_with_mnemonic(_("Open")); | ||
menu_data.item_open = gtk_menu_item_new_with_mnemonic(_("_Open")); | ||
gtk_widget_show(menu_data.item_open); | ||
gtk_menu_append(GTK_MENU (menu_data.menu), menu_data.item_open); | ||
g_signal_connect(menu_data.item_open, "activate", | ||
G_CALLBACK(item_open_workbench_activate_cb), NULL); | ||
geany_plugin_set_data(wb_globals.geany_plugin, menu_data.item_open, NULL); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And here, etc. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also removed. |
||
|
||
/* Create new menu item "Save Workbench" */ | ||
menu_data.item_save = gtk_menu_item_new_with_mnemonic(_("Save")); | ||
menu_data.item_save = gtk_menu_item_new_with_mnemonic(_("_Save")); | ||
gtk_widget_show(menu_data.item_save); | ||
gtk_menu_append(GTK_MENU (menu_data.menu), menu_data.item_save); | ||
g_signal_connect(menu_data.item_save, "activate", | ||
G_CALLBACK(item_save_workbench_activate_cb), NULL); | ||
geany_plugin_set_data(wb_globals.geany_plugin, menu_data.item_save, NULL); | ||
|
||
/* Create new menu item "Workbench Settings" */ | ||
menu_data.item_settings = gtk_menu_item_new_with_mnemonic(_("Settings")); | ||
menu_data.item_settings = gtk_menu_item_new_with_mnemonic(_("S_ettings")); | ||
gtk_widget_show(menu_data.item_settings); | ||
gtk_menu_append(GTK_MENU (menu_data.menu), menu_data.item_settings); | ||
g_signal_connect(menu_data.item_settings, "activate", | ||
G_CALLBACK(item_workbench_settings_activate_cb), NULL); | ||
geany_plugin_set_data(wb_globals.geany_plugin, menu_data.item_settings, NULL); | ||
|
||
/* Create new menu item "Close Workbench" */ | ||
menu_data.item_close = gtk_menu_item_new_with_mnemonic(_("Close")); | ||
menu_data.item_close = gtk_menu_item_new_with_mnemonic(_("_Close")); | ||
gtk_widget_show(menu_data.item_close); | ||
gtk_menu_append(GTK_MENU (menu_data.menu), menu_data.item_close); | ||
g_signal_connect(menu_data.item_close, "activate", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gtk_menu_append()
is deprecated for a long time in favor togtk_menu_shell_append()
, and its use breaks compilation under GTK3 which removed the former.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, replaced it.