addons/markword: Deselect when the selection changes #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eht16
reviewed
Oct 5, 2017
addons/src/ao_markword.c
Outdated
| @@ -190,6 +208,14 @@ void ao_mark_document_open(AoMarkWord *mw, GeanyDocument *document) | |||
| FALSE, | |||
| G_CALLBACK(on_editor_button_press_event), | |||
| mw); | |||
|
|
|||
| plugin_signal_connect( | |||
There was a problem hiding this comment.
This is the wrong place for the signal connect.
Here we connect to the signal on each opened document but never disconnect from it.
It would be better to re-use the already existing signal callback ao_editor_notify_cb in addons.c and add there a call to on_editor_notify after making it public.
eht16
approved these changes
Oct 8, 2017
Added a hook to clear the markers when the current selection is changed (eg. text was deleted, replaced etc). This will only take effect if 'single click deselect' is enabled in the preferences.
Problem: when text is highlighted, using the arrow keys will move the cursor outside the selection, without clearing it Feature added: listen for cursor movements and if there is no active selection(selection, not highlighting), clear the markers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if desired or not, but the marked results currently do not clear when the selected text is modified/deleted. The modification detects the deletion and clears the markers. Only works when single-click deselect is enabled.