Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeanyVC: Add support for a custom external diff viewer. #62

Closed
wants to merge 1 commit into from

Conversation

yqu
Copy link

@yqu yqu commented Jul 24, 2012

If "geany_external_diff" is found in the path, it is run as
the diff viewer. It can be a script or symbolic link to any
custom diff tool, easily modifiable by the user.
Otherwise the usual diff tools are tried as previously.

Also useful to add some command line arguments to the diff command.

If "geany_external_diff" is found in the path, it is run as
the diff viewer. It can be a script or symbolic link to any
custom diff tool, easily modifiable by the user.
Otherwise the usual diff tools are tried as previously.
@frlan
Copy link
Member

frlan commented Jul 26, 2012

Sorry. I'm not exactly sure what the goal behind the change is. Can you please go into more detail? Would be great.

@yqu
Copy link
Author

yqu commented Jul 26, 2012

Hi,
This change allows the user to use an external program of his choice to view the diff of the current file. In my case, I have a particular commercial program that I'd like to use instead of meld which is also installed on my machine.

This is one way to do it, another would be to have an environment variable override the builtin list of diff programs.

@b4n
Copy link
Member

b4n commented Jul 31, 2012

IMO a better implementation would be to allow the user to configure the external diff command in the plugin's configure dialog, it'd more easy to configure (and less hackish IMO). I think this shouldn't be too difficult to implement.

@yqu
Copy link
Author

yqu commented Aug 1, 2012

Yes, I will do that and update this pull request.

@frlan
Copy link
Member

frlan commented Aug 26, 2012

closing this pr until further feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants