Connect button-press signal handlers on plugin activation #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the plugin gets activated *after* Geany has been started already, we need to iterate all open documents and attach the "button-press" signal handler. Fixes geany#638.
|
Not sure wether it's layer 8 issue but when deactivating the plugin again, it's still marking |
b4n
reviewed
Oct 29, 2017
addons/src/ao_markword.c
Outdated
| /* if the plugin is loaded while Geany is already running, we need to connect the | ||
| * button press signal for open documents, if Geany is just booting, | ||
| * it happens automatically */ | ||
| if (main_is_realized()) |
There was a problem hiding this comment.
shouldn't this check for priv->enable_markword too, not to do that on deactivation as well?
There was a problem hiding this comment.
Uhhh, of course, thanks. Stupid me. Fixed in 71e26d8.
|
Hmmm. Weird. I'm pretty sure I tested it with a clean version. Will retest it with latest HEAD of that branch later and give feedback. Maybe just another layer 8 issue on my end :( |
|
Ah... Was an issue with automark-plugin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the plugin gets activated after Geany has been started already,
we need to iterate all open documents and attach the "button-press"
signal handler.
Fixes #638.