Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treebrowser: Use consistent capitalization in menu #641

Merged
merged 1 commit into from Oct 30, 2017

Conversation

medovina
Copy link
Contributor

Before this change, the treebrowser used an inconsistent mix of
capitalized and uncapitalized words in the context menu. This
changes them to all be capitalized for consistency with other
GTK applications.

Before this change, the treebrowser used an inconsistent mix of
capitalized and uncapitalized words in the context menu.  This
changes them to all be capitalized for consistency with other
GTK applications.
@frlan frlan merged commit 6700b02 into geany:master Oct 30, 2017
@elextr
Copy link
Member

elextr commented Oct 30, 2017

Maybe you should have reviewed this first.

@medovina
Copy link
Contributor Author

@elextr, I actually did look at that page while making this change, and generally followed the GNOME guideliines for header capitalization.

I chose to make only one difference from those guidelines: I used the capitalization "Create New File" rather than "Create new File". That's because "Create new File" looks strange to me since "new" is an important word in the menu item.

Is there some other text in this change that you are concerned about?

@elextr
Copy link
Member

elextr commented Oct 30, 2017

The New was the one I happened to notice :) And for me the lower case looks better but YMMV, if thats the only case then it doesn't matter.

@medovina
Copy link
Contributor Author

Actually, looking at this again I think I'd rather change those menu items like this:

Create New Directory -> New Folder
Create New File -> New File

This is shorter and would follow the capitalization guidelines, and is also more consistent with other GTK programs (e.g. Nautilus, gedit). OK with you?

@elextr
Copy link
Member

elextr commented Oct 30, 2017

Yeah, folder seems to be more common than directory, and shorter is (mostly) better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants