workbench: renamed "folder" to "sub-directory" #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGBI. I didn't check the code part in detail, and I personally would only have changed the user facing parts, not the internal names, but you have done it now, so thats fine. A couple of minor unrelated fixes to the readme noted. |
elextr
reviewed
Jan 18, 2018
workbench/README
Outdated
| @@ -85,7 +85,7 @@ These are the available items: | |||
| if you right clicked inside of a project. After selecting it a dialog | |||
| will be opened. Chosse the directory which shall be added. After that | |||
elextr
reviewed
Jan 18, 2018
workbench/README
Outdated
| @@ -101,18 +101,18 @@ These are the available items: | |||
| **Directory settings** | |||
| Select this item to change the directory settings. It is only available | |||
| if you right clicked inside of a project directory. In the directory | |||
| settings you can set a filter which controls the files and folders | |||
| settings you can set a filter which controls the files and sub-directories | |||
| that shall be displayed or not. | |||
There was a problem hiding this comment.
More idiomatic to say "will" in this context.
|
@elextr: fixed README also, thanks for reporting the typos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the naming convention in the workbench plugin from "folder" to "sub-directory".
@b4n, @elextr: please give some feedback as you two participated in the mail thread about the naming convention for directories and folders.